search

cofonseca / HipChatAdmin

A PowerShell module designed to interact with Atlassian HipChat.
6 stars 2 forks source link

Functions Should Output PSCustomObjects #8

Closed cofonseca closed 7 years ago

cofonseca commented 7 years ago

I would like to update each function to output a PSCustomObject, rather than just the HTTP status code. This will grant more flexibility when writing tests, and will provide more useful data to the user that can then be piped or otherwise used.

cofonseca commented 7 years ago

A working proof-of-concept has been added to Get-HipchatUser and seems to be working as expected. I will begin working on implementing this within the other functions.

ghost commented 7 years ago

I have submitted PR #13 for this issue.

cofonseca commented 7 years ago

@BrandonLundt thanks for contributing! I noted a couple of small issues in your PR. Happy to approve once those have been addressed.