Return 403 when appropriate, not 500 Internal Server Errors - Githubissues

coforma / acme-tech-challenge

For Phase 3 of the ACME Tech Challenge

3 stars 1 forks source link

Return 403 when appropriate, not 500 Internal Server Errors #103

Closed BearHanded closed 2 years ago

BearHanded commented 2 years ago

This PR

wraps the jwt decoding to throw an appropriate error that is translated to a 403 by Spring
handles errors thrown by the preauth(hasRole(...)) in the error handler to return better messages and codes
Removes an unused controller. The controller removed simpler returned findall for all of its endpoints ignoring params. According to other members of the team, it is not required.

closes #102