search

coforma / acme-tech-challenge

For Phase 3 of the ACME Tech Challenge
3 stars 1 forks source link

add maven wrapper and run unit tests in test script #108

Closed gmrabian closed 2 years ago

gmrabian commented 2 years ago

More info on Maven Wrapper here - allows us to run maven commands without downloading and setting up maven in the environment. Uses a local, small binary.

I added unit tests to the test script. It seems a little odd to run them after everything is deployed, but let me know what you think! We can of course add more api tests beyond this. I can move the unit tests earlier if you want. Just thought I'd put them all in the same place for now. (runs unit tests against the repo that is cloned in EC2)

bodnarbm commented 2 years ago

We talked offline. The tests actually run right now as part of the docker build process with mvn install, but since we hide docker output, the results are not visible. I think it is fine to include them here too.

@gmrabian You confirmed this runs on the AL2 boxes with just the 01-install-deps script already ran (meaning we have all the other dependencies needed)?

gmrabian commented 2 years ago

(answered offline before merging) Yep! No change to script 01. The wrapper serves all we need for maven here