coforma / swift-tech-challenge

MIT License

0 stars 0 forks source link

Details page #122

Closed gmrabian closed 5 months ago

gmrabian commented 6 months ago

Summary

Still need help with the styling and some formatting

Add router for clicking on college cards to get to details page

Fixes #36

Type of change

[x] New feature (non-breaking change which adds functionality)

How To Test

Export AWS credentials in your terminal
Run yarn dev
Open localhost:3000 and click on any college card
Ensure it navigates to a new page with the college id as the path
Ensure it shows information relevant to that college's data in the display

Checklist:

[x] My code follows the style guidelines of this project and has no linting errors
[x] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation, including any applicable ADRs
[ ] My changes generate no new warnings
[ ] I have added tests that fail without these changes
[ ] New and existing tests (unit, integration, accessibility) pass locally
[ ] Documentation updated
[ ] If there are security concerns they are addressed or ticketed after being discussed

codeclimate[bot] commented 5 months ago

Code Climate has analyzed commit 380fa0ed and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 99.4% (80% is the threshold).

This pull request will bring the total coverage in the repository to 97.0% (0.9% change).

View more on Code Climate.