coforma / swift-tech-challenge

MIT License
0 stars 0 forks source link

Add card icons and 'back to top' button #128

Closed braxex closed 8 months ago

braxex commented 8 months ago

Summary

We need icons for browse cards and a button on the browse page to take users back to the top. This PR adds both. Closes #77 Fixes #56 (issue)

Type of change

How To Test

  1. Pull and run app
  2. Observe the pleasant way the back-to-top button appears and disappears, and the gentleness of its scroll.
  3. Bask in the beauty of the icons on the cards.

Checklist:

codeclimate[bot] commented 8 months ago

Code Climate has analyzed commit 61db7275 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 98.0% (80% is the threshold).

This pull request will bring the total coverage in the repository to 95.3% (0.2% change).

View more on Code Climate.

TheDanMiller commented 8 months ago

@braxex two questions, not blockers.

  1. Can we delay when it pops a little bit> Maybe show the button when the apply filters moves out of sight or some other landmark like that
  2. Can we transition it out a little sooner, IMO it seems like its visible just a tad bit too long.
braxex commented 8 months ago

@TheDanMiller

Can we delay when it pops a little bit> Maybe show the button when the apply filters moves out of sight or some other landmark like that Can we transition it out a little sooner, IMO it seems like its visible just a tad bit too long.

Yep, we can tweak both of these when everything is finalized.