Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #144
Type of change
[x] Bug fix (non-breaking change which fixes an issue)
How To Test
Go to the homepage
Manually modify the path to be something that is not a college id
/123
/invalid
etc.
Verify the not-found page shows
Checklist:
[x] My code follows the style guidelines of this project and has no linting errors
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation, including any applicable ADRs
[x] My changes generate no new warnings
[ ] I have added tests that fail without these changes
[x] New and existing tests (unit, integration, accessibility) pass locally
[ ] Documentation updated
[ ] If there are security concerns they are addressed or ticketed after being discussed
Request for feedback
Is there a better way we could put this together? Additionally, should we consider putting the ids under a heading like /institutions/[id] or something so that there is some indication in the path what the id means?
Summary
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #144
Type of change
How To Test
/123/invalidChecklist:
Request for feedback
Is there a better way we could put this together? Additionally, should we consider putting the ids under a heading like
/institutions/[id]or something so that there is some indication in the path what the id means?