coforma / swift-tech-challenge

MIT License

0 stars 0 forks source link

Spinner functionality #152

Closed TheDanMiller closed 5 months ago

TheDanMiller commented 5 months ago

Add Spinner to home screen

Summary

Adds spinner and associated testing Fixes #150

Type of change

[x] New feature (non-breaking change which adds functionality)

How To Test

Refresh the browse page, see the spinner
Watch the spinner disappear when institutions load in
Back to top does not appear with spinner
Filter button appears opposite spinner

Checklist:

[x] My code follows the style guidelines of this project and has no linting errors
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation, including any applicable ADRs
[x] My changes generate no new warnings
[x] I have added tests that fail without these changes
[x] New and existing tests (unit, integration, accessibility) pass locally
[x] Documentation updated
[x] If there are security concerns they are addressed or ticketed after being discussed

codeclimate[bot] commented 5 months ago

Code Climate has analyzed commit de28af44 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (80% is the threshold).

This pull request will bring the total coverage in the repository to 87.8% (0.0% change).

View more on Code Climate.