search

cofounders / freyalove

Love is in the air.
2 stars 1 forks source link

FUNC: Login with Facebook Connect #29

Closed njyo closed 11 years ago

njyo commented 11 years ago

@veronism, please verify

sebdeckers commented 11 years ago

If she needs to verify (why, it's been working for weeks?) then you need to re-open the ticket.

sebdeckers commented 11 years ago

Implemented: a19f982d692d80536f344ac35d2585b28b78f667

njyo commented 11 years ago

As I had outlined in the instructions:

  1. Developer closes the issue once they say they are done.
  2. Somebody else verifies by giving it an "approved" label.

The reason why I asked @veronism to verify it is because I cannot see any proof of me logging in through Facebook right now (it could be all done through dummy data and I see no difference). So I thought that she'll be sitting with you, @cbas, fairly soon and can get it demonstrated to verify.

The whole point of verification is NOT to take the developer's word for it, but to check by oneself that things are done the way as expected..

sebdeckers commented 11 years ago

As soon as possible we should use ZombieJS/CucumberJS integration tests to verify these issues.

For now, here is a manual way to verify this specific issue:

  1. There is a Facebook "app permissions" popup the first time you sign in.
  2. Most APIs spit back errors if there is no FB token in the cookie. This token can only come from FB, not dummy data.
  3. Not all client API calls currently use dummy data. Some are always live.
  4. You can completely disable the dummy data as specified in the README.

As for the process, I appreciate that you took the initiative to propose a workflow. We've been using it for a week or so. Now it's time to do a retrospective. I've already been providing my feedback. I suggest we write down some of this in a guidelines document and discuss also with Veron/Sayanee.

On Tue, Aug 14, 2012 at 12:57 PM, Wolfgang Maehr notifications@github.comwrote:

As I had outlined in the instructions:

  1. Developer closes the issue once they say they are done.
  2. Somebody else verifies by giving it an "approved" label.

The reason why I asked @veronism https://github.com/veronism to verify it is because I cannot see any proof of me logging in through Facebook right now (it could be all done through dummy data and I see no difference). So I thought that she'll be sitting with you, @cbashttps://github.com/cbas, fairly soon and can get it demonstrated to verify.

The whole point of verification is NOT to take the developer's word for it, but to check by oneself that things are done the way as expected..

— Reply to this email directly or view it on GitHubhttps://github.com/cofounders/freyalove/issues/29#issuecomment-7716285.

njyo commented 11 years ago

This is my result with disabled dummy data: http://www.evernote.com/shard/s80/sh/865618f6-20ae-4d1e-9add-803d1bd00ac8/4c3e0ae32ad4837353be5052fd72ebce

Expected result: my Facebook information

Regarding the guidelines, I had written them down right at the start: Issue Tracker Guide