search

cog-imperial / OMLT

Represent trained machine learning models as Pyomo optimization formulations
Other
257 stars 56 forks source link

Increase execution timeout #124

Closed bammari closed 8 months ago

bammari commented 9 months ago

Increased execution timeout from 300 sec to 500 sec in notebook tests.

Legal Acknowledgement\ By contributing to this software project, I agree my contributions are submitted under the BSD license. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

codecov[bot] commented 9 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (c0f6c0b) 95.95% compared to head (b02e656) 95.95%. Report is 12 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #124 +/- ## ======================================= Coverage 95.95% 95.95% ======================================= Files 29 29 Lines 1656 1656 Branches 251 255 +4 ======================================= Hits 1589 1589 Misses 35 35 Partials 32 32 ``` [see 1 file with indirect coverage changes](https://app.codecov.io/gh/cog-imperial/OMLT/pull/124/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cog-imperial)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rmisener commented 9 months ago

Hi @bammari, thanks so much for doing this! Can you explain why changing a lower-case word to an upper-case word and running CI again makes all the tests pass? Seems really weird.

bammari commented 9 months ago

Hi @bammari, thanks so much for doing this! Can you explain why changing a lower-case word to an upper-case word and running CI again makes all the tests pass? Seems really weird.

@rmisener, sorry for the confusion! My access doesn't allow me to rerun CI so I committed a minor docstring change to kick off the workflow again. The deeper issue is this intermittent problem where tests pass but we get an error that the code coverage report fails to upload. Rerunning the CI one or more times typically resolves the issue however, we are currently looking into this as highlighted here: https://community.codecov.com/t/upload-issues-unable-to-locate-build-via-github-actions-api/3954

rmisener commented 9 months ago

Haha, I get it. I just gave you better access to the repo, you shouldn't need to make silly changes anymore to re-run CI.