search

cog-imperial / OMLT

Represent trained machine learning models as Pyomo optimization formulations
Other
273 stars 58 forks source link

Add GBT notebooks #20

Closed fracek closed 2 years ago

fracek commented 2 years ago

This PR made together with @ThebTron adds the notebooks for OMLT GBT module.

codecov[bot] commented 2 years ago

Codecov Report

Merging #20 (2c8de0a) into main (2c38689) will increase coverage by 0.04%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
+ Coverage   91.10%   91.14%   +0.04%     
==========================================
  Files          15       15              
  Lines         854      858       +4     
  Branches      159      159              
==========================================
+ Hits          778      782       +4     
  Misses         51       51              
  Partials       25       25
Impacted Files Coverage Δ
src/omlt/gbt/formulation.py 88.40% <100.00%> (+0.34%) :arrow_up:
src/omlt/gbt/model.py 95.55% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2c38689...2c8de0a. Read the comment docs.

fracek commented 2 years ago

I added the missing test. This PR is ready to be reviewed and merged.

carldlaird commented 2 years ago

@fracek Looks reasonable to me. I will merge this with the layer-formulation branch