search

cog-imperial / OMLT

Represent trained machine learning models as Pyomo optimization formulations
Other
262 stars 57 forks source link

remove categorical vars #36

Closed ThebTron closed 2 years ago

ThebTron commented 2 years ago

This PR removes functions to handle categorical vars from the main branch as ONNX currently doesn't allow for categorical vars. I'll be adding these functions to a separate branch after the PR is closed and link it to #37 so we don't lose any of the progress.

codecov[bot] commented 2 years ago

Codecov Report

Merging #36 (efdd40a) into main (b0ccafd) will increase coverage by 1.29%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
+ Coverage   88.79%   90.08%   +1.29%     
==========================================
  Files          23       23              
  Lines        1071     1049      -22     
  Branches      160      154       -6     
==========================================
- Hits          951      945       -6     
+ Misses         98       85      -13     
+ Partials       22       19       -3
Impacted Files Coverage Δ
src/omlt/gbt/gbt_formulation.py 93.60% <100.00%> (+9.92%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b0ccafd...efdd40a. Read the comment docs.