jalving commented 2 years ago

This should fix the full-space CNN bug we were seeing in one of the notebooks, but please review @fracek. As discussed, we should add some CNN tests. We can either add them to this PR, or merge now and tests later.

codecov[bot] commented 2 years ago

Codecov Report

Merging #38 (73aed5a) into main (b0ccafd) will increase coverage by 1.20%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #38      +/-   ##
==========================================
+ Coverage   88.79%   90.00%   +1.20%     
==========================================
  Files          23       23              
  Lines        1071     1050      -21     
  Branches      160      153       -7     
==========================================
- Hits          951      945       -6     
+ Misses         98       86      -12     
+ Partials       22       19       -3

Impacted Files	Coverage Δ
src/omlt/neuralnet/layers/full_space.py	`58.82% <0.00%> (-1.79%)`	:arrow_down:
src/omlt/gbt/gbt_formulation.py	`93.60% <0.00%> (+9.92%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b0ccafd...73aed5a. Read the comment docs.

fracek commented 2 years ago

I added a simple CNN in #35, so I think it's better to add tests after we merge that.

cog-imperial / OMLT

update full-space cnn #38

Codecov Report