cog-imperial / OMLT

Represent trained machine learning models as Pyomo optimization formulations
Other
262 stars 57 forks source link

update notebooks to pass tests #40

Closed jalving closed 2 years ago

jalving commented 2 years ago

This PR should hopefully get the notebook tests to pass. I updated all of the neural network formulations to use the final names we picked. I also had to make some adjustments to build_network.ipynb.

codecov[bot] commented 2 years ago

Codecov Report

Merging #40 (7ea43b5) into main (4bbb84a) will decrease coverage by 0.27%. The diff coverage is 82.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
- Coverage   90.00%   89.72%   -0.28%     
==========================================
  Files          23       23              
  Lines        1050     1090      +40     
  Branches      153      163      +10     
==========================================
+ Hits          945      978      +33     
- Misses         86       90       +4     
- Partials       19       22       +3     
Impacted Files Coverage Δ
src/omlt/neuralnet/activations/__init__.py 100.00% <ø> (ø)
src/omlt/neuralnet/layers/full_space.py 58.82% <0.00%> (ø)
src/omlt/io/keras_reader.py 89.47% <33.33%> (-10.53%) :arrow_down:
src/omlt/neuralnet/nn_formulation.py 93.16% <87.75%> (-2.15%) :arrow_down:
src/omlt/formulation.py 92.53% <100.00%> (+0.47%) :arrow_up:
src/omlt/gbt/gbt_formulation.py 93.60% <100.00%> (ø)
src/omlt/neuralnet/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bc67c43...7ea43b5. Read the comment docs.

jalving commented 2 years ago

The tests now pass, but we lost some coverage, interestingly.

Also, I am guilty of changing notebook meta-data that I didn't need to (e.g. auto-thermal-reformer shows I changed the python version because I ran it locally and committed it). We should discuss how we want to handle meta-data fields in these notebooks for testing purposes.

Also @fracek: I had to make some changes to build_network.ipynb to get it to run. I think some cells were deprecated by the layer_formulation PR. It might be worth checking it over.

jalving commented 2 years ago

wait to merge this. I will check against the new notebooks in main.