search

cog-imperial / OMLT

Represent trained machine learning models as Pyomo optimization formulations
Other
257 stars 56 forks source link

add dependencies to setup.cfg #50

Closed jalving closed 2 years ago

jalving commented 2 years ago

this adds numpy to the omlt dependencies.

should we also add onnx? The onnx reader requires it. Otherwise the user will just get an error.

same for tensorflow. we now use tensorflow.keras to read a keras sequential model. I don't think it should be a dependency, but maybe a more descriptive error when they try to use the keras reader?

codecov[bot] commented 2 years ago

Codecov Report

Merging #50 (569ee9c) into main (04e0232) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #50   +/-   ##
=======================================
  Coverage   91.14%   91.14%           
=======================================
  Files          24       24           
  Lines        1231     1231           
  Branches      186      186           
=======================================
  Hits         1122     1122           
  Misses         80       80           
  Partials       29       29

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 04e0232...569ee9c. Read the comment docs.

rmisener commented 2 years ago

Oops, I see that better handling for onnx and tensorflow is going to go in an issue, let's go with that.