search

cog-imperial / OMLT

Represent trained machine learning models as Pyomo optimization formulations
Other
273 stars 58 forks source link

Rename project to omlt #8

Closed fracek closed 2 years ago

fracek commented 2 years ago

I'm not 100% sure if we should capitalize the name as OMLT or Omlt, especially in code (OMLTBlock vs OmltBlock).

rmisener commented 2 years ago

I vote OmltBlock since I find it easier to read.

jalving commented 2 years ago

I am okay either way. The best examples with acronyms I can find are GDPoptSolver and SMTSatSolver from pyomo.contrib solvers.

I would also go with OmltBlock since OMLTBlock is not immediately obvious.

fracek commented 2 years ago

I agree that OmltBlock is the best name. You can merge the PR and then tomorrow I'll release omlt on PyPi.

jalving commented 2 years ago

Would we still prefer the actual name to be OMLT like the logo spells it? Kind of like how ONNX is the package name, but it is spelled onnx everywhere in the code.

fracek commented 2 years ago

Ok I updated the documentation.