coganlab / IEEG_Pipelines

A repo of current preprocessing methods for the Cogan Lab

https://ieeg-pipelines.readthedocs.io/en/latest/

MIT License

4 stars 2 forks source link

Current extraction method does not record which trials were removed #30

Closed Aaronearlerichardson closed 1 year ago

Aaronearlerichardson commented 1 year ago

With the iteration here: https://github.com/coganlab/IEEG_Pipelines/blob/b01a39991e3f0978f684601fde01eee4b4ec5ec6/MATLAB/ieegClassDefinition/extractHGDataWithROI.m#L1

It does not record which trials were removed, it only removes them. This is a problem when trying to apply the trialInfo data to the new set because there's no way to know which trials to remove from trialInfo without backtracking through the structclass function and coding it by hand, which sort of defeats the convenience of the function.

Aaronearlerichardson commented 1 year ago

29

Aaronearlerichardson commented 1 year ago

I make extractTrialInfo Task agnostic by commenting out the following snippet: https://github.com/coganlab/IEEG_Pipelines/blob/b6933ab04bdfe2af045e751c02846e0897c7aa1c/MATLAB/ieegClassDefinition/extractTrialInfo.m#L52-L57 Now this script mirrors the behavior of extractHGDataWithROI.m but with the trialInfo. This fixes the issue for now

Aaronearlerichardson commented 1 year ago

Issue not fixed because https://github.com/coganlab/IEEG_Pipelines/blob/b01a39991e3f0978f684601fde01eee4b4ec5ec6/MATLAB/ieegClassDefinition/extractHGDataWithROI.m#L1 needs to include removed trials data