cogciprocate / ocl

OpenCL for Rust
Other
723 stars 75 forks source link

you are deriving `Hash` but have implemented `PartialEq` explicitly #145

Closed kpp closed 5 years ago

kpp commented 5 years ago

Errors from clippy:

error: you are deriving `Hash` but have implemented `PartialEq` explicitly
   --> ocl-core/src/types/abs.rs:338:30
    |
338 | #[derive(Clone, Copy, Debug, Hash, Eq)]
    |                              ^^^^
    |
    = note: #[deny(clippy::derive_hash_xor_eq)] on by default
note: `PartialEq` implemented here
   --> ocl-core/src/types/abs.rs:378:1
    |
378 | / impl PartialEq<PlatformId> for PlatformId {
379 | |     fn eq(&self, other: &PlatformId) -> bool {
380 | |         self.0 == other.0
381 | |     }
382 | | }
    | |_^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq

error: you are deriving `Hash` but have implemented `PartialEq` explicitly
   --> ocl-core/src/types/abs.rs:400:30
    |
400 | #[derive(Clone, Copy, Debug, Hash, Eq)]
    |                              ^^^^
    |
note: `PartialEq` implemented here
   --> ocl-core/src/types/abs.rs:446:1
    |
446 | / impl PartialEq<DeviceId> for DeviceId {
447 | |     fn eq(&self, other: &DeviceId) -> bool {
448 | |         self.0 == other.0
449 | |     }
450 | | }
    | |_^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq
c0gent commented 5 years ago

Removed now unnecessary manual implementations (bc88dbae9e0adce0904fe27248b246ff3d72ae66).

Thanks!

kpp commented 5 years ago

Pushed to master without PR?

c0gent commented 5 years ago

Yup.

kpp commented 5 years ago

Why not use github Pull Request features? Please turn on TravisCI for this repo in https://travis-ci.org/account/repositories, I will setup CI for you.