cogent3 / c3dev

cogent3 developer tools
5 stars 9 forks source link

Checking git hooks #38

Closed fredjaya closed 11 months ago

fredjaya commented 11 months ago

Pre-commit hooks Currently, the pre-commit script will print a success message regardless if black/isort fails.

Related to #23

Pre-push hooks Currently, all test sessions are run (see: output) and pushing to origin fails.

fredjaya commented 11 months ago

@GavinHuttley is it ok to include black and isort as part of the c3dev conda environment, or better to install via e.g. pip until #23 is implemented?

nox as well? #36

GavinHuttley commented 11 months ago

All of these tools are specified in the pyproject.toml. I am going to delete all conda environment files.

We should be instructing users how to make a "blank" conda environment, or python virtual environment, for the correct python version and do a "developer install" using flit from their cloned repository.

Closing this issue, leaving the pre-commit hook for possibly a derivative of #23