search

cogentapps / chat-with-gpt

An open-source ChatGPT app with a voice
https://www.chatwithgpt.ai
MIT License
2.29k stars 485 forks source link

Replace create react app with vite #164

Closed ZauberNerd closed 12 months ago

ZauberNerd commented 1 year ago

~~This PR builds upon https://github.com/cogentapps/chat-with-gpt/pull/163 and thus includes the changes from that PR as well. If #163 gets merged, the diff in this PR will be smaller. For reviewing purposes, you could check out the "Commits" tab and review the commits separately.~~

create-react-app seems to struggle a bit https://github.com/reactjs/react.dev/pull/5487#issuecomment-1409720741 and many folks are recommending vite as an alternative, as that project is more active. For me the reason to switch to vite is to reduce dependencies and speed up the build process.

Replacing create-react-app with vite reduce the number of dependencies from 1762 to 444.

I was also quite surprised, by how small the actual diff in this commit is. From that perspective there is almost no discernible difference between the two tools.

Not sure, if you are up for any major changes, I just forked this repository and started tinkering a bit - feel free to close it if it doesn't fit in your vision.

:warning: Please note that I didn't test this extensively, so further testing to verify that all features still work as expected is required. :warning:

cogentapps commented 1 year ago

Thanks for working on this!

I’ll need some time to review and test it out, but from a quick skim it looks good, and I agree with the reasoning for switching away from CRA.

cogentapps commented 12 months ago

Looks good, merging. Thanks again, this is great work!