search

cogentcore / core

A free and open source framework for building powerful, fast, elegant 2D and 3D apps that run on macOS, Windows, Linux, iOS, Android, and the web with a single Go codebase, allowing you to Code Once, Run Everywhere.
http://cogentcore.org/core
BSD 3-Clause "New" or "Revised" License
1.73k stars 82 forks source link

Resolve Vulkan location and structure #1018

Closed kkoreilly closed 2 months ago

kkoreilly commented 3 months ago

Describe the feature

If we continue to use Vulkan, we should move https://github.com/goki/vulkan somewhere into the Cogent Core space, try again to merge it upstream, or use a better Vulkan package. We may also use WebGPU instead (see #507).

Relevant code

No response

theclapp commented 3 months ago

While you're at it, it might (or, of course, might not) be useful to look at some of the other forks of vulkan-go/vulkan (https://github.com/vulkan-go/vulkan/network) for useful code and/or bug fixes. And perhaps even some of their open PRs.

I mention this in part because I ran into a bug in a library I'd forked, and committed a fix, and went to upstream, only to see that they had an unmerged PR to fix the same issue that was two years old. So I was bitter about that, but my point is sometimes there's useful code in other people's forks and/or PRs.

Apologies if you've already thought of all that. :)

kkoreilly commented 3 months ago

Thank you for the suggestion! I think we already merged any other useful forks into our fork in addition to the improvements we made ourselves. Regardless, we are planning to migrate to WebGPU now (#507), so hopefully all of these issues will become irrelevant.

rcoreilly commented 3 months ago

I didn't know about that /network feature! very handy.