Margin is still getting events

cogentcore / core

A free and open source framework for building powerful, fast, elegant 2D and 3D apps that run on macOS, Windows, Linux, iOS, Android, and the web with a single Go codebase, allowing you to Code Once, Run Everywhere.

http://cogentcore.org/core

BSD 3-Clause "New" or "Revised" License

1.7k stars 79 forks source link

Margin is still getting events #773

Closed kkoreilly closed 8 months ago

rcoreilly commented 8 months ago

Benefits:

Splitter and other handles
in general larger touch targets on mobile (could change stying to make bigger still)

Cons:

Close button on tabs, which can easily be solved by using a space instead of margin, like it used to be.

If Kai can get over his unexplained allergy of the Space and Stretch elements, it seems obvious that this is a net win all around.

kkoreilly commented 8 months ago

Cons: major violation of the CSS spec, end-user and programmer expectations, and event handling consistency.

kkoreilly commented 8 months ago

We have decided to have margin continue to receive events, as that makes more logical sense and makes splits and other elements work more elegantly and effectively, especially on mobile. The issues with close buttons on tabs have been resolved by using Space elements, as stated in #581.