search

cogentcore / core

A free and open source framework for building powerful, fast, elegant 2D and 3D apps that run on macOS, Windows, Linux, iOS, Android, and the web with a single Go codebase, allowing you to Code Once, Run Everywhere.
http://cogentcore.org/core
BSD 3-Clause "New" or "Revised" License
1.7k stars 79 forks source link

windows are still not fully closing #805

Closed rcoreilly closed 7 months ago

rcoreilly commented 8 months ago

if you close all the windows in an app, the app itself should quit, due to the wait condition. this often, but not always, happens.

rcoreilly commented 8 months ago

Looks like it might be stuck in a mutex hang around the rendercursor in texteditor.

rcoreilly commented 8 months ago

we were not even deleting the window contents -- now doing that, and destroy closes the cursor -- looks like it is fixed. will reopen if recurs.

rcoreilly commented 8 months ago

this is now happening semi-reliably (but not exactly reproducible). things look like they are in some kind of zombie-like state when I debug attach. maybe some recent goosi / event loop change for testing stuff? @kkoreilly ?

kkoreilly commented 8 months ago

I don't think I have done anything recently that could have caused this.

rcoreilly commented 8 months ago

I added more direct route to turning off cursor which seemed to be the problem - now working

rcoreilly commented 8 months ago

yep, happening again: just caught one in the act -- waiting on the texteditor.ViewBlinker channel (just renamed to EditorBlink*) in texteditor/cursor.go -- need a quit cleanup call..

rcoreilly commented 8 months ago

also for same thing in textfield

kkoreilly commented 8 months ago

Fixed in c129af4.

rcoreilly commented 8 months ago

its baaak... definitely happening.

rcoreilly commented 7 months ago

My simulations in axon are now 100% reliably not closing.

rcoreilly commented 7 months ago

furthermore, I can verify that a build from 2/14 did close (immediately after starting), while the same thing built now fails to quit. thus, it was a relatively recent change

rcoreilly commented 7 months ago

@kkoreilly this is happening in demo too. please fix.