default spacing is really too big

[rcoreilly]

Describe the bug

maybe have that be the default on mobile, but on desktop, it is just crazy spaced for a default.

How to reproduce

run anything. expt with spacing option in settings.

Example code

No response

Relevant output

No response

Platform

macOS

[ddkwork]

I have same problem

[kkoreilly]

This is simply not true. Our current default spacing is good for user-friendly applications and is consistent with that of Material Design. The user is always free to set the spacing to something else.

[ddkwork]

I have same thing

not working

[kkoreilly]

The appearance settings zoom and spacing are based around 0-100, not 0-1, so those should be 50 and 70, respectively. However, again, I would recommend against hardcoding the settings in your code, as that prevents people from changing them. I will look into figuring out better default spacing settings, but you should not force your opinion in your app; on some computers, you need a much bigger or smaller zoom. Once you set your settings in the app, they will be saved and persist for all apps on that device.

[ddkwork]

Again, I feel like you're pointing out the maze, it's strange that my Android phone and tablet are very suitable for this ratio, by the way, I also have an all-in-one computer and another laptop next to me, I'll compile exe to them later for testing, if the ratio is still appropriate, then I'm here for 4 devices that are suitable for this ratio, and I'll report back to you after I test, after all, I can't see the less tested.

---Original--- From: @.> Date: Thu, Feb 29, 2024 23:43 PM To: @.>; Cc: @.**@.>; Subject: Re: [cogentcore/core] default spacing is really too big (Issue #909)

The appearance settings zoom and spacing are based around 0-100, not 0-1, so those should be 50 and 70, respectively. However, again, I would recommend against hardcoding the settings in your code, as that prevents people from changing them. I will look into figuring out better default spacing settings, but you should not force your opinion in your app; on some computers, you need a much bigger or smaller zoom. Once you set your settings in the app, they will be saved and persist for all apps on that device.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

[ddkwork]

[ddkwork]

Unfortunately, I can't install the VK driver for the other two devices, they are old devices and don't support VK, so I can't test it, so let's do it first, regardless of this problem, just adjust it manually

---Original--- From: @.> Date: Thu, Feb 29, 2024 23:43 PM To: @.>; Cc: @.**@.>; Subject: Re: [cogentcore/core] default spacing is really too big (Issue #909)

The appearance settings zoom and spacing are based around 0-100, not 0-1, so those should be 50 and 70, respectively. However, again, I would recommend against hardcoding the settings in your code, as that prevents people from changing them. I will look into figuring out better default spacing settings, but you should not force your opinion in your app; on some computers, you need a much bigger or smaller zoom. Once you set your settings in the app, they will be saved and persist for all apps on that device.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

[kkoreilly]

Did you restart the app after you changed the system scaling factor? Do you have a different font size specified in your accessibility settings? Can you send me a screenshot of Inspect > Inspect app > Screens > right click > Edit?

[ddkwork]

After the zoom in the system settings is adjusted to 100%, the whole system is quite small, the mouse is difficult to step text, start menu, explorer and the like, it is not easy to operate, this can be a low priority, and when I find out that there is a computer that supports VK driver, I will further test it and report the results to you

---Original--- From: @.> Date: Fri, Mar 1, 2024 04:33 AM To: @.>; Cc: @.**@.>; Subject: Re: [cogentcore/core] default spacing is really too big (Issue #909)

Did you restart the app after you changed the system scaling factor? Do you have a different font size specified in your accessibility settings? Can you send me a screenshot of Inspect > Inspect app > Screens > right click > Edit?

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

[ddkwork]

Did you restart the app after you changed the system scaling factor? Do you have a different font size specified in your accessibility settings? Can you send me a screenshot of Inspect > Inspect app > Screens > right click > Edit?

is this ?

[kkoreilly]

Yes. It says that you have a Device pixel ratio of 1.5, which means that it thinks your system has 150% zoom. Can you show me a screenshot of that same page with your system widgets (taskbar, etc) included, with the system zoom and Cogent Core zoom at 100% and the app restarted to show the difference between the system and Cogent Core?

[ddkwork]

2762713521 @.***

 

------------------ 原始邮件 ------------------ 发件人: "cogentcore/core" @.>; 发送时间: 2024年3月1日(星期五) 上午10:47 @.>; @.**@.>; 主题: Re: [cogentcore/core] default spacing is really too big (Issue #909)

Yes. It says that you have a Device pixel ratio of 1.5, which means that it thinks your system has 150% zoom. Can you show me a screenshot of that same page with your system widgets (taskbar, etc) included, with the system zoom and Cogent Core zoom at 100% and the app restarted to show the difference between the system and Cogent Core?

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

[kkoreilly]

It says that it is an invalid address.

[ddkwork]

wait me，sorry

[ddkwork]

[kkoreilly]

For me, the Cogent Core file view is only slightly bigger than the Windows one. Can you send a screenshot of the same thing (the Cogent Core file view alongside the Windows one). Also, are you sure your zoom and spacing are set to 100 in the Cogent Core settings?

[ddkwork]

[ddkwork]

//this looks like well to me

func Test_well(t *testing.T) {
    zoom, spacing := well(150)
    assert.Equal(t, float64(50), zoom)
    assert.Equal(t, float64(70), spacing)

    zoom, spacing = well(100)
    assert.Equal(t, float64(0), zoom)
    assert.Equal(t, float64(20), spacing)
}

func well(systemScale float64) (zoom, spacing float64) {
    return systemScale - 100, systemScale - 80
}