cogeotiff / rio-tiler

User friendly Rasterio plugin to read raster datasets.
https://cogeotiff.github.io/rio-tiler/
BSD 3-Clause "New" or "Revised" License
502 stars 106 forks source link

S3 STAC item may not load properly after pystac 1.10 #699

Open emmanuelmathot opened 4 months ago

emmanuelmathot commented 4 months ago

After a change in pystac 1.10 that performs a load of all the absolute links in a STAC item , the stac reader may not load properly the assets the item. See https://github.com/stac-utils/pystac/issues/1336 for more details.

A further change to ensure consistency in rio-tiler would be to replace the boto3 loader in STAC reader with a custom S3 reader as recommended in https://pystac.readthedocs.io/en/stable/concepts.html#i-o-in-pystac

vincentsarago commented 4 months ago

😬 I'm not sure to fully get what need to be changed 😬

emmanuelmathot commented 4 months ago

For the moment, just avoiding using pystac version 1.10 until https://github.com/stac-utils/pystac/issues/1336 is fixed. But then for a future PR I will make, the idea would be to have the STAC S3 fetch function to use pystac only with a custom IO reader that enable S3 in pystac when S3 is enabled in rio-tiler