search

cogeotiff / rio-tiler

User friendly Rasterio plugin to read raster datasets.
https://cogeotiff.github.io/rio-tiler/
BSD 3-Clause "New" or "Revised" License
502 stars 106 forks source link

use width/height in `get_vrt_transform` when overzooming a dataset #701

Closed vincentsarago closed 4 months ago

vincentsarago commented 4 months ago

This PR re-add width and height parameters to the get_vrt_transform (removed in #648) but will only be used when over-zooming a dataset

cc @amarouane-ABDELHAK @j08lue

amarouane-ABDELHAK commented 4 months ago

Thank you for offering a permanent solution to the issue. It was indeed a challenge to identify the cause of the visualization problem. I wonder why we didn't think of integrating these additional lines of code into the existing pull request rather than starting a new one.

vincentsarago commented 4 months ago

@amarouane-ABDELHAK

I wonder why we didn't think of integrating these additional lines of code into the existing https://github.com/cogeotiff/rio-tiler/pull/700 rather than starting a new one.

It was the fastest way for me to work on this issue and also make sure to get the results from the benchmark. If you care about ownership for this 2 lines change I could refactor this PR but I can't promise to get everything on time

vincentsarago commented 4 months ago

@DanSchoppe this PR will change a bit the behaviour we introduced in #648

Resampling will have effect only when not overzooming a dataset, when over-zooming it's kinda default to nearest.

This may impact you. I'm happy to discuss more to find a solution for your specific use case later