Add browse by album (patch included)

[GoogleCodeExporter]

(I'm not sure if this is the right place to post patches, but I couldn't find a 
better place to)

TunesRemote+ can show the list of all artists, or all playlists, but not a list 
of all albums from all artists. The attached patch adds such a list to the menu.

Attached is a patch that adds such a list, together with the icon I used for 
the menu, which I lifted from AOSP Music package (and is thus Apache-licensed, 
AFAIK).

A side-effect is that this pushes the shuffle command out of the menu for the 
now playing screen. I plan on transforming the search results into a tabbed 
interface, similar to the music app, but would first like to know if there's 
even interest adding this.

Original issue reported on code.google.com by s...@shayel.org on 30 Oct 2010 at 8:29

Attachments:

• add-all-albums.diff
• ic_search_category_music_album.png

[GoogleCodeExporter]

Let me check with tsouthen he is the other committer.  Any interest in being a 
committer on this project?

Original comment by mellowaredev on 31 Oct 2010 at 2:21

• Changed state: Accepted

[GoogleCodeExporter]

Original comment by mellowaredev on 31 Oct 2010 at 2:25

[GoogleCodeExporter]

Original comment by mellowaredev on 31 Oct 2010 at 2:25

[GoogleCodeExporter]

Thanks.

And yes, I'd be glad to.

Original comment by s...@shayel.org on 31 Oct 2010 at 2:57

[GoogleCodeExporter]

OK I just added you as a committer.  I also just assigned you your first defect.

http://code.google.com/p/tunesremote-plus/issues/detail?id=6

Original comment by mellowaredev on 31 Oct 2010 at 3:00

[GoogleCodeExporter]

Original comment by mellowaredev on 31 Oct 2010 at 11:02

[GoogleCodeExporter]

I tried this patch and the screen gets stuck in an infinite loop and then 
crashes.  It keeps making the following call over  and over:

11-15 10:52:02.519: DEBUG/class org.tunesremote.daap.Library(374): readAlbums() 
requesting start=4400 of total=2147483647

Original comment by mellowaredev on 15 Nov 2010 at 3:52

[GoogleCodeExporter]

Suspected it would happen, didn't think it would after such a small number of 
items.

I don't have much free time I can afford right now, so it'd take me a while to 
do this correctly. No need to merge this now.

Original comment by s...@shayel.org on 15 Nov 2010 at 3:57

[GoogleCodeExporter]

changed priority and type to enhancement.

Original comment by mellowaredev on 30 Nov 2010 at 8:30

• Added labels: Priority-Low, Type-Enhancement
• Removed labels: Priority-Medium, Type-Defect

[GoogleCodeExporter]

Any News on this Issue? Saw also a couple comments on the Market when looking 
at the newest Version that the Album browse is still an anticipated feature ;)

Original comment by cramermaurice@gmail.com on 29 Jun 2011 at 9:10

[GoogleCodeExporter]

The original patch developer never got back involved, haven't heard from him in 
a long time.

Original comment by mellowaredev on 29 Jun 2011 at 10:13

[GoogleCodeExporter]

An answer from the original developer:

Hi, sorry for taking long to answer.

I didn't really gave it a look -- lack of time and lack of interest both (I no 
longer use itunes to play music,) made the itch not itching, to borrow a phrase.

I won't promise, but if I could find some free time next week I'll give it a 
look and try to get it fixed.

-Shay

Original comment by cramermaurice@gmail.com on 2 Jul 2011 at 9:12

[GoogleCodeExporter]

Reassigning to aml.curran

Original comment by mellowaredev on 8 Jun 2012 at 2:20

[GoogleCodeExporter]

Original comment by aml.cur...@gmail.com on 24 Jun 2012 at 2:12

• Changed state: Started

[GoogleCodeExporter]

new BETA released in Downloads area containing this new code.

I also bumped the version in AndroidManifest.xml to 2.4.3 so please do an SVN 
update.

Original comment by mellowaredev on 25 Jun 2012 at 12:49

[GoogleCodeExporter]

Original comment by mellowaredev on 25 Jun 2012 at 12:49

• Changed state: Accepted
• Removed labels: Type-Enhancement

[GoogleCodeExporter]

Original comment by mellowaredev on 25 Jun 2012 at 12:50

• Added labels: Type-Enhancement

[GoogleCodeExporter]

OK now that I have the latest BETA working on 2.3 I attached the log.  I have a 
lot of albums and it is grabbing 50 albums at a time until I get an Out Of 
Memory Exception.  It should probably only grab the first 50 on load and then 
if they scroll give them the option of "More..." or something like that.  That 
is how the Apple remote does it.

07-02 12:35:45.776: D/class org.tunesremote.daap.Library(373): readAlbums() 
requesting start=550 of total=2147483647
07-02 12:35:45.786: D/class org.tunesremote.daap.RequestHelper(373): started 
request(remote=http://192.168.139.207:3689/databases/1282481453/groups?session-i
d=657309469&meta=dmap.itemname,dmap.itemid,dmap.persistentid,daap.songartist&typ
e=music&group-type=albums&sort=album&include-sort-headers=1&index=550-600)
07-02 12:35:45.815: D/class org.tunesremote.daap.ResponseParser(373): 
ResponseParser performSearch...
07-02 12:35:46.745: D/class org.tunesremote.daap.Library(373): readAlbums() 
requesting start=600 of total=2147483647
07-02 12:35:46.745: D/class org.tunesremote.daap.RequestHelper(373): started 
request(remote=http://192.168.139.207:3689/databases/1282481453/groups?session-i
d=657309469&meta=dmap.itemname,dmap.itemid,dmap.persistentid,daap.songartist&typ
e=music&group-type=albums&sort=album&include-sort-headers=1&index=600-650)
07-02 12:35:46.775: D/class org.tunesremote.daap.ResponseParser(373): 
ResponseParser performSearch...
07-02 12:35:47.675: D/class org.tunesremote.daap.Library(373): readAlbums() 
requesting start=650 of total=2147483647
07-02 12:35:47.675: D/class org.tunesremote.daap.RequestHelper(373): started 
request(remote=http://192.168.139.207:3689/databases/1282481453/groups?session-i
d=657309469&meta=dmap.itemname,dmap.itemid,dmap.persistentid,daap.songartist&typ
e=music&group-type=albums&sort=album&include-sort-headers=1&index=650-700)
07-02 12:35:47.715: D/class org.tunesremote.daap.ResponseParser(373): 
ResponseParser performSearch...
07-02 12:35:48.555: D/class org.tunesremote.daap.Library(373): readAlbums() 
requesting start=700 of total=2147483647
07-02 12:35:48.555: D/class org.tunesremote.daap.RequestHelper(373): started 
request(remote=http://192.168.139.207:3689/databases/1282481453/groups?session-i
d=657309469&meta=dmap.itemname,dmap.itemid,dmap.persistentid,daap.songartist&typ
e=music&group-type=albums&sort=album&include-sort-headers=1&index=700-750)
07-02 12:35:48.596: D/class org.tunesremote.daap.ResponseParser(373): 
ResponseParser performSearch...

Original comment by mellowaredev on 2 Jul 2012 at 12:45

Attachments:

• tr-error.log

[GoogleCodeExporter]

OK instead of looping 50 at a time the latest beta just grabs the whole album 
list at once.  Seems to work pretty fast on mine and prevents the OOM Exception.

Original comment by mellowaredev on 2 Jul 2012 at 4:43

[GoogleCodeExporter]

2.5.0 Released to Android Market

Original comment by mellowaredev on 4 Jul 2012 at 2:34

• Changed state: Fixed