Migrate to Model Registry V2

cogment / cogment-verse

Research platform for Human-in-the-loop learning (HILL) & Multi-Agent Reinforcement Learning (MARL)

https://cogment.ai/cogment_verse

Apache License 2.0

80 stars 15 forks source link

Migrate to Model Registry V2 #144

Closed wduguay-air closed 1 year ago

wduguay-air commented 1 year ago

closes #120

Overview

This pull request migrates the current Model Registry implementation to the Model Registry V2 implementation introduced by the SDK in release v2.5.0.

Testing

The functional tests will be added to the PR after merging the Functional Test PR https://github.com/cogment/cogment-verse/pull/143.

[x] Functional Test PR merged
[x] Functional Tests added

Other changes

Modified some existing functional test configs to have a faster execution time.

wduguay-air commented 1 year ago

Since the last review/conversation, I removed the model_registry implemented locally in cogment-verse, in favor of entirely using the python sdk version. I also change the Model class to implement the same methods (serialize_model, deserialize_model) as other recent cogment projects.

Yves-air commented 1 year ago

Maybe you can have a look at some of the new functionality coming, to see if it would make sense to wait for the next version (excluding enterprise stuff): https://gitlab.com/ai-r/cogment/cogment-doc/-/merge_requests/155

wduguay-air commented 1 year ago

Anyways I was planning to wait a bit to wait for Ha to merge some agent implementations PRs that have been open for a long time. But for now, the current functionalities seem enough for the general cogment-verse use case. I will probably make a new PR in the near future to include them!

wduguay-air commented 1 year ago

All implementations PRs I was waiting for are merged. This is ready.

Yves-air commented 1 year ago

I would suggest you go through and change model_version for model_iteration everywhere.

The code also does not follow our coding guidelines, but it might be too much for this PR.

wduguay-air commented 1 year ago

I just made a pass to rename to model_version to model_iteration. For the code guidelines, I will create a separate task to make a pass over the entire repo in the near future.