search

cognitect-labs / aws-api

AWS, data driven
Apache License 2.0
727 stars 100 forks source link

Log which method of credential fetching succeeded #217

Closed brettrowberry closed 1 year ago

brettrowberry commented 2 years ago

When I look through logs of my app starting up, I can see which credential fetch methods failed. I would love to also have a log message saying which method worked.

Dependencies

{:deps 
  {com.cognitect.aws/api            {:mvn/version "0.8.524"}}
  {com.cognitect.aws:secretsmanager {:mvn/version "814.2.1008.0"}}

Description with failing test case

What I see:

Unable to fetch credentials from system properties.
Unable to fetch credentials from environment variables.

What I expect to see:

Unable to fetch credentials from system properties.
Unable to fetch credentials from environment variables.
Fetched credentials from <method>.

Stack traces

N/A

dchelimsky commented 1 year ago

Done in 7352ec647ff19f6a14cbbfc5e581c48a8183ebf1 h/t @MissInterpret . Will be in the next release.

dchelimsky commented 1 year ago

Released in 0.8.630

brettrowberry commented 1 year ago

Thanks!