search

cognitect-labs / vase

Data driven microservices
Eclipse Public License 1.0
374 stars 40 forks source link

Interceptor names should be unique. #15

Closed ddeaguiar closed 8 years ago

ddeaguiar commented 8 years ago

Built-in interceptors now have api-specific names as well as meta-data.

ddeaguiar commented 8 years ago

ping @ohpauleez. There's some duplication that can be refactored out if need be but I wanted to run this by you before going further.

ohpauleez commented 8 years ago

Nobody merge this PR

Since these interceptors are not (originally) programmatically generated, their namespaced names are fine -- the interceptor name always resolves to exactly the same interceptor. They should probably be updated to use namespaced keys though, like ::attach-received-time.

I want to avoid using metadata for all core functionality. Metadata can be added by some consumer of Vase if they wish to use it.

ddeaguiar commented 8 years ago

Closing this PR. A new PR will be submitted which only includes the api description interceptor name change.