Uniquely name the describe-api interceptor.

cognitect-labs / vase

Data driven microservices

Eclipse Public License 1.0

374 stars 40 forks source link

Closed ddeaguiar closed 8 years ago

ddeaguiar commented 8 years ago

Since this interceptor is created programmatically, it's name should be unique.

ddeaguiar commented 8 years ago

ping @ohpauleez

ohpauleez commented 8 years ago

Consider something based on (keyword "vase" (str (gensym "describe-api")))

ddeaguiar commented 8 years ago

Yep, forgot a ns. Good point.

ohpauleez commented 8 years ago

You've been having the best attitude digging into all of this. Thanks!

ddeaguiar commented 8 years ago

Np! I should've added the prefix to gensym as you demonstrated. Sorry about that!

ddeaguiar commented 8 years ago

@ohpauleez pong. Sorry for the back-and-forth and thanks for your patience.

ohpauleez commented 8 years ago

Looks good! Thanks!

Dumb question, but have you signed a Cognitect contributor's agreement?

ddeaguiar commented 8 years ago

I signed some sort of agreement ages ago. May have been a Relevance one? I'm on this page: http://clojure.org/community/contributors (ddeaguiar).

ohpauleez commented 8 years ago

The good news: The one agreement is used across Pedestal, Transit, Vase -- all Cognitect projects.

ddeaguiar commented 8 years ago

Ok. Signed and submitted. Thanks for pointing this out!

ohpauleez commented 8 years ago

Thanks so much!