Closed milt closed 7 years ago
Thanks for this. I'm currently adding test cases to exercise more of the literals. Once I get those in place, I'll pull this in as the fix. Holding off on the merge until then.
Cool! BTW, there should be a signed contributor agreement for Yetanalytics already, but let me know if you don't see it.
@milt I'll ask @ohpauleez to check on the CA.
In the meantime, I wanted to improve our testability with query & transact actions, so I ended up going a different direction with the tests. At that point, it was easier to just fix the issue directly on master than to merge this PR.
I agree, those tests are way better. Thanks!
Provides a fix for #46
The use of
mapcat
in...actions/query-action-exprs
works fine for a single parameter, but causes multiple parameters to be lumped into a single invocation of...actions/coerce-arg-val
. Using mapv and removing the enclosing vector fixes this.A test for this specific behaviour was also added to the actions tests.