Update dependencies to use Clojure 1.9.0-alpha17 and clojure.spec.alpha

cognitect-labs / vase

Data driven microservices

Eclipse Public License 1.0

373 stars 42 forks source link

Closed deg closed 6 years ago

deg commented 7 years ago

Use latest Clojure alpha, for the sake of dependent projects.

Note:

Required temporary explicit include of the latest core.async, to avoid dragging in all of pedestal.service 0.5.3-SNAPSHOT.
I did not update any of the sample projects included in this repo. They remain happily depending on earlier versions of everything.

ohpauleez commented 7 years ago

Thanks @deg for pulling this together and helping make Vase better!

A few things:

Can you undo the docstring changes? We specifically use clojure.spec there because there is also a notion of an "API Spec" and a "Vase Spec" -- this helps keep it clear which "spec" we're talking about.
I would prefer to use full namespaced items within syntax quoted sections (even if it is fragile against changes like this).

deg commented 7 years ago

Ok, will have in a few minutes.

At test/com/cognitect/vase/conform_test.clj L17,23, do you also want to change to use full namespaced? Or only in the syntax-quoted sections?

deg commented 7 years ago

Added your changes.
Did not change back the lines in conform_tests. I don't know which way is better. Feel free to change, or ask me to change this, if you want.
Caught some places I had missed: namespace refs in the .edn files used by the tests, and exclusion in the project.clj generated by the template.

frenchy64 commented 7 years ago

Is there anything left to do for the PR? I'm happy to contribute to avoid maintaining a fork.

deg commented 7 years ago

As far as I know, this is done.