search

cognitect-labs / vase

Data driven microservices
Eclipse Public License 1.0
373 stars 42 forks source link

Remove deprecated javax.xml.bind.DatatypeConverter dep for Java9 comp… #95

Closed thosmos closed 5 years ago

thosmos commented 6 years ago

based on the same fix used in Clojurescript here: https://github.com/clojure/clojurescript/commit/544c1b77d76d48f234cdb03746ea993158c46aff

ohpauleez commented 6 years ago

Thanks for pulling this together! I think we should just collapse the bytes-to-base64-str into the short hash function.

thosmos commented 6 years ago

Should I make another PR with the several commits squashed into one?

ohpauleez commented 6 years ago

Thanks for making the changes! No worries about squashing, but I appreciate you asking. Have you signed a Cognitect Contributor's Agreement before?

thosmos commented 6 years ago

I've filled out the Rich Hickey CA as linked from https://clojure.org/community/contributing, but using my old github username "thos37". I thought I sent another CA a while back with my current username "thosmos", but it's still the old one on the list. You can see my username change message here: https://github.com/thos37 It looks like the CA form is broken at the moment (name field is not editable)

neuromantik33 commented 5 years ago

Any chance this can get merged one day? This is quite a show stopper for running any vase application with Java11

ddeaguiar commented 5 years ago

I found no CA. I made the change in the context of other changes so closing this PR.

thosmos commented 5 years ago

I found no CA. I made the change in the context of other changes so closing this PR.

My CA is under my username "thosmos" at https://clojure.org/community/contributors

ddeaguiar commented 5 years ago

Ok, sorry about that. I was apparently looking in the wrong place.

thosmos commented 5 years ago

Ok, sorry about that. I was apparently looking in the wrong place.

No problem! I'm glad the fix got committed!