search

cognitect / transit-cljs

Transit for ClojureScript
http://transit-format.org
Apache License 2.0
324 stars 21 forks source link

Transit’s UUID should be IComparable to cljs.core/UUID and vice versa #11

Closed tonsky closed 9 years ago

swannodette commented 9 years ago

fixed https://github.com/cognitect/transit-cljs/commit/e4ec6ab3a5b852034f4cad8f48fc394956f3a6c3

tonsky commented 9 years ago

The test is not testing UUID compare, it compares strings. Test should lose pr-str under compare

swannodette commented 9 years ago

Nice catch will fix

swannodette commented 9 years ago

After further review, this is blocked on the fact that compare is broken in ClojureScript wrt. to Clojure semantics http://dev.clojure.org/jira/browse/CLJS-1200

swannodette commented 9 years ago

fixed in transit-cljs 0.8.220 when combined with ClojureScript 0.0-3308