search

cognitect / transit-cljs

Transit for ClojureScript
http://transit-format.org
Apache License 2.0
323 stars 20 forks source link

Bump transit-js dep in pom.xml to fix metadata encoding #46

Closed mk closed 6 years ago

mk commented 6 years ago

Trying to encode metadata in our project didn't work as expected, setting the :transform option just didn't have an effect. Tests are passing here because project.clj is using another version of transit than pom.xml.

https://github.com/cognitect/transit-cljs/blob/ada722e56f0dafd230ef3f5b4d2c1e6b09511c40/project.clj#L7

https://github.com/cognitect/transit-cljs/blob/ada722e56f0dafd230ef3f5b4d2c1e6b09511c40/pom.xml#L134-L136

As a workaround, adding a explicit require in deps.edn on the latest transit-js fixed the issue for me:

com.cognitect/transit-js {:mvn/version "0.8.861"}

I'm happy to provide a PR for this one-line change in pom.xml it it helps.

puredanger commented 6 years ago

Done - I'll @swannodette do the release as needed.