com$cognitect$transit$ctor$guid breaks on multiple instances

cognitect / transit-format

A data interchange format.

1.88k stars 36 forks source link

com$cognitect$transit$ctor$guid breaks on multiple instances #12

Closed moll closed 10 years ago

moll commented 10 years ago

Hey,

One might end up with multiple instances of Transit under Node.js when multiple libraries require it. However, those instances may be given handlers serializing the same classes. The GUID there isn't really a GUID, but a counter, which will collide given this situation.

Either make the it a true GUID to prevent this or rename the com$cognitect$transit$ctor$guid to contain something random and local to a particular Transit insttance.

swannodette commented 10 years ago

Sure will look into it.

moll commented 10 years ago

I'm sorry, I created this issue in the wrong repository. It should've gone into https://github.com/cognitect/transit-js/. I got too trigger happy. Would you like me to recreate it there?

swannodette commented 10 years ago

@moll yes please.