search

cognitect / transit-format

A data interchange format.
1.87k stars 36 forks source link

Link should use correct map format in JSON #19

Closed syslo closed 9 years ago

syslo commented 9 years ago

JSON's Link representation is specified as: ["~#link" , {"href": "~rhttp://...", "rel": "a-rel", "name": "a-name", "render": "link or image", "prompt": "a-prompt"}] However, I believe that it should be ["~#link" , ["^ ", "href", "~rhttp://...", "rel", "a-rel", "name", "a-name", "render", "link or image", "prompt", "a-prompt"]] since Link is not a ground type and it has to follow Map's representation.

jlouis commented 9 years ago

I agree on this one. Also, note there are no test cases in this repository which cover the link representation, so implementations are unlikely to conform to these rules.

timewald commented 9 years ago

Yes, this is a typo for the format of link in JSON. Fixed.