search

cognitect / transit-ruby

Apache License 2.0
113 stars 24 forks source link

Add Rubinius to Supported Rubies in README. #11

Closed brixen closed 10 years ago

brixen commented 10 years ago

I ran the specs with Rubinius 2.2.10 and all passed as seen below.

Is there any interest in testing on Travis CI? If yes, I can send a PR to enable that as well.

Thanks!

$ bundle exec rspec
Run options: include {:focus=>true, :focused=>true}

All examples were filtered out; ignoring {:focus=>true, :focused=>true}
..........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................

Finished in 2.88 seconds (files took 4.01 seconds to load)
842 examples, 0 failures
yokolet commented 10 years ago

Hi Brian, thanks for looking at transit-ruby so soon.

But, we have a policy on pull requests, https://github.com/cognitect/transit-ruby#contributing . Also, nobody have thought of Rubinius while developing the gem (sorry!). Before adding Rubinius to the list, we should discuss about the supported Rubies among transit-ruby devs (Cognitect internally). For now, I'd suggest you to join transit-format google group, https://groups.google.com/forum/#!forum/transit-format , and post there the topic of Rubinius support.

One more about CI. At this moment, it's not clear what CI will be used for transit-ruby. Once CI server is chosen, I (or other transit-ruby devs) will add a setup script.

yokolet commented 9 years ago

Hi @brixen Just let you know. We had the wiki page, https://github.com/cognitect/transit-format/wiki/Community-Implementations , and Rubinius is there. Probably, Cognitect won't support Rubinius officially (won't test transit on Rubinius), but would maintain the list.

brixen commented 9 years ago

@yokolet thank you for letting me know! What would we need to do to get Rubinius officially tested?