Fix up time encoding benchmark

cognitect / transit-ruby

Apache License 2.0

113 stars 24 forks source link

Fix up time encoding benchmark #12

Closed jgdavey closed 10 years ago

jgdavey commented 10 years ago

Use bmbm for VM warming
Update outdated API calls

dchelimsky commented 10 years ago

Hey @jgdavey, thanks for the contribution but, per https://github.com/cognitect/transit-ruby#contributing we're not accepting any pull requests from anybody outside Cognitect in any of the transit repos. Good changes, though, which I'll gladly adopt and credit you for.

dchelimsky commented 10 years ago

BTW - the other 1/2 of that policy is that we do welcome conversation in https://groups.google.com/forum/#!forum/transit-format. So if you have any ideas about design choices (overall or Ruby-specific), implementation details, etc, please feel free to bring them up in that forum.

jgdavey commented 10 years ago

Thanks for the clarification. I should have read the contributing section more closely. I'll redirect any subsequent suggestions to the mailing list.

Thanks!

dchelimsky commented 10 years ago

FYI - I moved the https://github.com/cognitect/transit-ruby#contributing higher up the page - will hopefully help save ppl from doing a bunch of work for naught.