search

cognitect / transit-ruby

Apache License 2.0
113 stars 24 forks source link

Loosen addressable dependency requirement #20

Closed tdg5 closed 7 years ago

tdg5 commented 7 years ago

Hello!

I was just wondering if it might be possible to loosen the dependency on addressable? Currently, the requirement is ~> 2.3.6, and I was hoping that it might be possible to loosen the requirement by dropping the patch portion of the version so the new requirement would be ~> 2.3.

The more strict requirement is giving me dependency trouble given the popularity of the addressable library. I tried reducing the restriction and ran the specs on MRI 2.3.0 and didn't have any problems.

Alternatively, if you want to bump the dependency to ~> 2.5.0, that'd help my problem in the near term, but I may be back again to bug you later.

I created a branch here with the change if it happens to interest you: https://github.com/tdg5/transit-ruby/tree/loosen-addressable-requirement

Here's the specific diff: https://github.com/tdg5/transit-ruby/commit/f6ec54ffdcae9039bb6a4d3d5721dbeb6f29a76e

If I can answer any questions or offer any other assistance, please let me know. Thanks!

maiwald commented 7 years ago

Hi there,

we would really like to use transit as well and this is unfortunately preventing uns from using it.

dchelimsky commented 7 years ago

I'll try to take a look at this on Friday.

devn commented 7 years ago

Bumping because we needed to fork to deal with this, but I would have preferred not to.

dchelimsky commented 7 years ago

I've got this addressed on a branch but I have to do some more testing across Ruby versions (specifically JRuby versions) before releasing. Probably won't get to that before this coming Friday, but it's in progress.

dchelimsky commented 7 years ago

Fixed in 99795d3 Released in transit-ruby-0.8.602