cognitedata / oryx

.NET Cross platform and highly composable middleware for building web request handlers in F#
Apache License 2.0
202 stars 10 forks source link

Fix FSharp.Core to 7 #131

Closed einarmo closed 1 year ago

einarmo commented 1 year ago

We have a transitive dependency on this, and the current setup causes a package downgrade error in all downstream packages, requiring them all to pick a version of FSharp.Core, which isn't great, especially as most downstream packages aren't written in F#.

The error happens because FsToolkit.ErrorHandling depends on FSharp.Core 7.

This also needs to be changed in the SDK.

codecov[bot] commented 1 year ago

Codecov Report

Merging #131 (acf2f46) into master (8fd8ad7) will increase coverage by 0.14%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #131      +/-   ##
==========================================
+ Coverage   76.66%   76.80%   +0.14%     
==========================================
  Files           9        9              
  Lines         677      677              
  Branches       39       39              
==========================================
+ Hits          519      520       +1     
  Misses        131      131              
+ Partials       27       26       -1     

see 1 file with indirect coverage changes

polomani commented 1 year ago

it seems like the recommendation is to pin the version https://github.com/dotnet/fsharp/blob/main/docs/fsharp-core-notes.md#package-authors-should-pin-their-fsharpcore-reference

polomani commented 1 year ago

Maybe we pin it to nuget FSharp.Core >= 7.0.0 in that case?