search

cognitedata / reveal-viewer

WebGL viewer for high-performance visualization of large 3D models
2 stars 0 forks source link

Selecting a node id does not select all geometries with that id #10

Closed dragly closed 5 years ago

dragly commented 5 years ago

Only some parts of the geometries that correspond to the node id are selected (via @f1cognite).

anderscognite commented 5 years ago

This may be a bug with the backend. @f2cognite I asked you about this, did you find anything?

f2cognite commented 5 years ago

I think I looked into it but didn't find anything; but I can double-check if you give me the details again

anderscognite commented 5 years ago

I just looked at 

project: 3ddemo
modelId: 4291994125741328
revisionId: 968271980052890

And found that nodeId 2570168472089215 has treeIndex 15. When I parse the file with 3d-web-parser, I find the following geometries with treeIndex 0:

Found 0, 2570168472089215 of type BoxGroup
Found 0, 2570168472089215 of type BoxGroup
Found 0, 4781679390810252 of type BoxGroup
Found 0, 4781679390810252 of type BoxGroup
Found 0, 4781679390810252 of type BoxGroup
Found 0, 4781679390810252 of type BoxGroup
Found 0, 4781679390810252 of type BoxGroup
Found 0, 4781679390810252 of type BoxGroup
Found 0, 1097152192836546 of type BoxGroup
Found 0, 1097152192836546 of type BoxGroup
Found 0, 1097152192836546 of type BoxGroup
Found 0, 1097152192836546 of type BoxGroup
Found 0, 1097152192836546 of type BoxGroup
Found 0, 1097152192836546 of type BoxGroup
Found 0, 2570168472089215 of type BoxGroup
Found 0, 3501626813932326 of type BoxGroup
Found 0, 2570168472089215 of type BoxGroup
Found 0, 2570168472089215 of type BoxGroup
Found 0, 1905926201588721 of type CircleGroup
Found 0, 1905926201588721 of type CircleGroup
Found 0, 1503762993736444 of type CircleGroup
Found 0, 7755540475735041 of type CircleGroup
Found 0, 1905926201588721 of type CircleGroup
Found 0, 1905926201588721 of type CircleGroup
Found 0, 1503762993736444 of type CircleGroup
Found 0, 7755540475735041 of type CircleGroup
Found 0, 1503762993736444 of type CircleGroup
Found 0, 1503762993736444 of type CircleGroup
Found 0, 7755540475735041 of type CircleGroup
Found 0, 7755540475735041 of type CircleGroup
Found 0, 7755540475735041 of type CircleGroup
Found 0, 1905926201588721 of type CircleGroup
Found 0, 1905926201588721 of type CircleGroup
Found 0, 1503762993736444 of type CircleGroup
Found 0, 1503762993736444 of type CircleGroup
Found 0, 7755540475735041 of type CircleGroup
Found 0, 1905926201588721 of type CircleGroup
Found 0, 1905926201588721 of type CircleGroup
Found 0, 1503762993736444 of type CircleGroup
Found 0, 1503762993736444 of type CircleGroup
Found 0, 1503762993736444 of type CircleGroup
Found 0, 1503762993736444 of type CircleGroup
Found 0, 1503762993736444 of type CircleGroup
Found 0, 7755540475735041 of type CircleGroup
Found 0, 1503762993736444 of type CircleGroup
Found 0, 1905926201588721 of type CircleGroup
Found 0, 1905926201588721 of type CircleGroup
Found 0, 1503762993736444 of type CircleGroup
Found 0, 1905926201588721 of type CircleGroup
Found 0, 7755540475735041 of type CircleGroup
Found 0, 7755540475735041 of type CircleGroup
Found 0, 1905926201588721 of type CircleGroup
Found 0, 8585272562056348 of type CircleGroup
Found 0, 7755540475735041 of type CircleGroup
Found 0, 1905926201588721 of type CircleGroup
Found 0, 7755540475735041 of type CircleGroup
Found 0, 1905926201588721 of type CircleGroup
Found 0, 1503762993736444 of type CircleGroup
Found 0, 1905926201588721 of type CircleGroup
Found 0, 7755540475735041 of type CircleGroup
Found 0, 1503762993736444 of type CircleGroup
Found 0, 1503762993736444 of type CircleGroup
Found 0, 1503762993736444 of type CircleGroup
Found 0, 1905926201588721 of type CircleGroup
Found 0, 1905926201588721 of type CircleGroup
Found 0, 7755540475735041 of type CircleGroup
Found 0, 1503762993736444 of type CircleGroup
Found 0, 1503762993736444 of type CircleGroup
Found 0, 1503762993736444 of type CircleGroup
Found 0, 1503762993736444 of type CircleGroup
Found 0, 1503762993736444 of type CircleGroup
Found 0, 1503762993736444 of type CircleGroup
Found 0, 1503762993736444 of type CircleGroup
Found 0, 7755540475735041 of type CircleGroup
Found 0, 1905926201588721 of type CircleGroup
Found 0, 1905926201588721 of type CircleGroup
Found 0, 6830412002659435 of type CircleGroup
Found 0, 6830412002659435 of type CircleGroup
Found 0, 5292074263253086 of type CircleGroup
Found 0, 4409206100046680 of type CircleGroup
Found 0, 4409206100046680 of type CircleGroup
Found 0, 4409206100046680 of type CircleGroup
Found 0, 4409206100046680 of type CircleGroup
Found 0, 4409206100046680 of type CircleGroup
Found 0, 4409206100046680 of type CircleGroup
Found 0, 4409206100046680 of type CircleGroup
Found 0, 5292074263253086 of type CircleGroup
Found 0, 6830412002659435 of type CircleGroup
Found 0, 6830412002659435 of type CircleGroup
Found 0, 4409206100046680 of type CircleGroup
Found 0, 4409206100046680 of type CircleGroup
Found 0, 4409206100046680 of type CircleGroup
Found 0, 5292074263253086 of type CircleGroup
Found 0, 6830412002659435 of type CircleGroup
Found 0, 4409206100046680 of type CircleGroup
Found 0, 6830412002659435 of type CircleGroup
Found 0, 5292074263253086 of type CircleGroup
Found 0, 6830412002659435 of type CircleGroup
Found 0, 7536943307376201 of type CircleGroup
Found 0, 5292074263253086 of type CircleGroup
Found 0, 7536943307376201 of type CircleGroup
Found 0, 6830412002659435 of type CircleGroup
Found 0, 5292074263253086 of type CircleGroup
Found 0, 5292074263253086 of type CircleGroup
Found 0, 6830412002659435 of type CircleGroup
Found 0, 4409206100046680 of type CircleGroup
Found 0, 6830412002659435 of type CircleGroup
Found 0, 6830412002659435 of type CircleGroup
Found 0, 4409206100046680 of type CircleGroup
Found 0, 5292074263253086 of type CircleGroup
Found 0, 4409206100046680 of type CircleGroup
Found 0, 4409206100046680 of type CircleGroup
Found 0, 4409206100046680 of type CircleGroup
Found 0, 4409206100046680 of type CircleGroup
Found 0, 6830412002659435 of type CircleGroup
Found 0, 6830412002659435 of type CircleGroup
Found 0, 5292074263253086 of type CircleGroup
Found 0, 4409206100046680 of type CircleGroup
Found 0, 4409206100046680 of type CircleGroup
Found 0, 6830412002659435 of type CircleGroup
Found 0, 6830412002659435 of type CircleGroup
Found 0, 5292074263253086 of type CircleGroup
Found 0, 5292074263253086 of type CircleGroup
Found 0, 5292074263253086 of type CircleGroup
Found 0, 4409206100046680 of type CircleGroup
Found 0, 4409206100046680 of type CircleGroup
Found 0, 5292074263253086 of type CircleGroup
Found 0, 4409206100046680 of type CircleGroup
Found 0, 6830412002659435 of type CircleGroup
Found 0, 6830412002659435 of type CircleGroup
Found 0, 5292074263253086 of type CircleGroup
Found 0, 4409206100046680 of type CircleGroup
Found 0, 6830412002659435 of type CircleGroup
Found 0, 6830412002659435 of type CircleGroup
Found 0, 1905926201588721 of type ConeGroup
...

This comes right from the parser. One of these circles look like this from the protobuf data:

Screenshot 2019-06-03 14 08 33

Can you check with your tools if there is a parsing problem or the file has bad data?

f2cognite commented 5 years ago

Indeed seems like the file is bad. I've opened an issue in the backend for this.

f2cognite commented 5 years ago

I can't seem to reproduce this with the files that are produced by the optimizer today (that is, version 5 or 6). Since the model in question had file format version 4, I suggest we don't spend time trying to fix this, and instead reprocess the models that have this problem.

anderscognite commented 5 years ago

That was protobuf btw!

anderscognite commented 5 years ago

This bug was fixed in the backend I think.