fix: add uuid to injected spinner style dom node to avoid race condition

nabati commented 2 weeks ago

when using mutiple reveal instances on the same page

Type of change

Jira ticket :blue_book:

no ticket

Thread for reference: https://cognitedata.slack.com/archives/C8A0QGMLN/p1715853617765619

Description :pencil:

When using multiple reveal components on a single page, if one of them unmounts then the styles would get destroyed for the other ones as well. This refactors the Spinner styleId to be an instance variable and assings a unique id to each instance.

How has this been tested? :mag:

Did not test :)

Test instructions :information_source:

Not sure :)

Checklist :ballot_box_with_check:

[ ] I am proud of this feature.
[ ] I have performed a self-review of my own code.
[ ] I have added PR type (Feat, Bug, Chore, Test, Docs, Style, Refactor) to the PR title.
[ ] I have manually tested this for different scenarios (different models, formats, devices, browsers).
[ ] I have commented my code in hard-to-understand areas.
[ ] I have made corresponding changes to the public documentation.
[ ] I have added unit and visuals tests to prove that my feature works to the best of my ability.
[ ] I have refactored the code for readability to the best of my ability.
[ ] I have checked that my changes do not introduce regressions in the public documentation.
[ ] I have outlined any known defects / lacking capabilities in the contents of this PR.
[ ] I have listed any remaining work that should follow this PR in the description or jira/miro/etc.
[ ] I have added TSDoc to any public facing changes.
[ ] I have added "developer documentation" in any package README.md that is related / applicable to this PR.
[ ] I have noted down and am currently tracking any technical debt introduced in this PR.
[ ] I have thoroughly thought about the architecture of this implementation.
[ ] I have asked peers to test this feature.

github-actions[bot] commented 2 weeks ago

There were failures in the visual tests workflow. Image diffs for visual tests can be downloaded as an artifact here.

github-actions[bot] commented 1 week ago

There were failures in the visual tests workflow. Image diffs for visual tests can be downloaded as an artifact here.

github-actions[bot] commented 1 week ago

There were failures in the visual tests workflow. Image diffs for visual tests can be downloaded as an artifact here.

cognitedata / reveal