search

cognitive-catalyst / watson-beat

Other
102 stars 46 forks source link

Typo on string #15 #12

Closed kant closed 6 years ago

bclark288 commented 6 years ago

I'm a little new to GitHub. I notice there are two of you active and I'd like to join the conversation. I have used watson beats on about 30 songs so far and I have made a couple changes to make my work easier. The biggest change was to create only one midi file for each layer instead of having a midi file for each layer and section. Is that something others would be interested in? Also, I'm now looking at how chord progressions and melodies are created and it would be great to have someone who can help me understand the code.

amchaney commented 6 years ago

Hi @bclark288 ... I do think making one midi per instrument would be a good option for people running the watson beat code. I don't want to use it that way, since it makes it harder for me to edit the tracks after processing, but it would make it easier to get started. If you want to contribute, the way forward would be adding a command line option to request that there is one instrument per track, then switching on that option while writing the midi files. You would create a pull request containing just these changes, then someone (most likely me) would evaluate the changes to make sure they worked and, if they did, they would be merged into the master branch.

bclark288 commented 6 years ago

Hi,

I have made the changes to make one midi per layer a command line option. As I mentioned, I’m a little new to GitHub. I did some reading about pull requests, but I noticed there aren’t any branches other than the master. I don’t want to step on anyone’s code, so I’m a little unsure what to do next.

On Jun 11, 2018, at 12:30 PM, amchaney notifications@github.com wrote:

Hi @bclark288 https://github.com/bclark288 ... I do think making one midi per instrument would be a good option for people running the watson beat code. I don't want to use it that way, since it makes it harder for me to edit the tracks after processing, but it would make it easier to get started. If you want to contribute, the way forward would be adding a command line option to request that there is one instrument per track, then switching on that option while writing the midi files. You would create a pull request containing just these changes, then someone (most likely me) would evaluate the changes to make sure they worked and, if they did, they would be merged into the master branch.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/cognitive-catalyst/watson-beat/pull/12#issuecomment-396304278, or mute the thread https://github.com/notifications/unsubscribe-auth/ALSko0U9EUknK8sgOrESA3_21ApcihiBks5t7ps0gaJpZM4UDN7M.

amchaney commented 6 years ago

@bclark288 ... this is a good article to read on how you should create a Pull Request (PR) https://akrabat.com/the-beginners-guide-to-contributing-to-a-github-project/

bclark288 commented 6 years ago

Hi,

Thanks for the article. It was very helpful. I’m ready to create the pull request now. It’s been a few weeks (I was traveling), so I thought I would give you a heads-up. Let me know if it’s ok to go ahead and create the PR.

On Jun 14, 2018, at 3:38 PM, amchaney notifications@github.com wrote:

@bclark288 https://github.com/bclark288 ... this is a good article to read on how you should create a Pull Request (PR) https://akrabat.com/the-beginners-guide-to-contributing-to-a-github-project/ https://akrabat.com/the-beginners-guide-to-contributing-to-a-github-project/ — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/cognitive-catalyst/watson-beat/pull/12#issuecomment-397414028, or mute the thread https://github.com/notifications/unsubscribe-auth/ALSko3nCbpnvr3210W70SQN-UKS0jmYWks5t8rufgaJpZM4UDN7M.

amchaney commented 6 years ago

sure, create a PR! I might not review it right away (I'm 3 PRs behind on my day job right now) but I promise I will get to it eventually :-)

bclark288 commented 6 years ago

I have created the PR. No big hurry on getting it done. I am curious about what is happening with the project. Are you with IBM? I’m a music technology student at Ga. Tech. This software seems to be a very good fit with the research I want to do over the next couple of years. It would be nice to know what’s in store for this project.

On Jul 11, 2018, at 9:23 AM, amchaney notifications@github.com wrote:

sure, create a PR! I might not review it right away (I'm 3 PRs behind on my day job right now) but I promise I will get to it eventually :-)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/cognitive-catalyst/watson-beat/pull/12#issuecomment-404167150, or mute the thread https://github.com/notifications/unsubscribe-auth/ALSko6_ssKfBYiGVrbEIRehw8-9K6KH7ks5uFfxjgaJpZM4UDN7M.