search

cognitivecomputations / OpenChatML

147 stars 10 forks source link

Wolfram Ravenwolf's comments #5

Closed WolframRavenwolf closed 6 months ago

WolframRavenwolf commented 6 months ago

Hey Eric, you said you welcome PRs, so here's one based on my comment from https://github.com/cognitivecomputations/OpenChatML/issues/4 – feel free to cherrypick the parts you agree with, and let's discuss those you don't agree with.

ehartford commented 6 months ago

Imma revamp this concept, I have something new brewing.

ehartford commented 6 months ago

So for the sake of discussion

1) Regarding switching and to EOS and BOS - instead of defining this here, we will instead use the predefined EOS and BOS tokens in the base model. This will be different from model to model. I will update the spec.

2) regarding Thought block - I'm going to depart from quiet star here, and implement my own analysis scheme. It will be 3 blocks - reflect, introspect, and reason