adding support for TEXT fields, remove non-standard ascii characters

[odedelharar]

Added a very basic TEXT field support, while removing non-ascii characters from such a field. Updated the date and datetime fields to support string representations of unix time.

[cognitom]

@odedelharar thank you for your PR! LGTM about TEXT type. I like it 👍

I assumed that DATE and DATETIME type are string like 2016-11-07 basically. Could you change the code to pass such values?

The code could be like this:

convert: val => {
  if (!val) return 'NULL'
  if (typeof val == 'number') val = moment(val).format('YYYY-MM-DD')
  if (typeof val == 'string') {
    if (/\d+/.test(val)) val = moment(parseInt(val)).format('YYYY-MM-DD')
    if (!/\d{4}-\d{2}-\d{2}/.test(val)) return 'NULL'
  }
  return `"${ val }"`
}

[cognitom]

Could you pls add documentation about TEXT to here, too? Thanks.

[odedelharar]

Updated, now can allow: date format string (YYYY-MM-DD), unix time (number), unix time (string). Can make more options viable, maybe in a future change

[cognitom]

Great! Thank you.

[odedelharar]

Maybe add an expression like: /[\x00-\x1F\x7F\uFFFD\xEF\xBF\xBD]/g so it also covers the cases I saw

[cognitom]

@odedelharar unfortunately, it seems not a good idea. These chars like \xBF \xBD are actually valid letters in some languages.

[odedelharar]

OK, so maybe we can use /[\x00-\x1F\x7F\uFFFD]/g since \uFFFD (�) is not OK anyway.