Closed yoshi6jp closed 8 years ago
Thanks! Basically LGTM 👍 Have you considered to use an object like this? :
export.config = {
// ...
services: ['phantomjs'],
phantomjsOpts: {
webdriverLogfile: 'phantomjs.log',
ignoreSslErrors: true
}
// ...
}
PhantomJS provides the way via config.json
so we could follow the naming convention of that.
http://phantomjs.org/api/command-line.html#command-line-options
In my opinion
export.config = {
// ...
services: ['phantomjs'],
phantomjsArgs: [
'--config=/path/to/config.json'
]
// ...
}
{
"ignoreSslErrors": true
}
wdio-sauce-service handles options well. They convert --arg
to { option }
here:
https://github.com/bermi/sauce-connect-launcher/blob/master/lib/process_options.js
We'd rather follow them?
Super cool! Thanks. I'm merging this.
@yoshi6jp now version 0.2.2 has been published 😄
Because of some issues (#3, #4), it took a time.
added phantomjsArgs options.