search

cognoma / figshare

A package for downloading and uploading figshare data
Other
24 stars 10 forks source link

Update README.md to demonstrate how to use #7

Closed astrochun closed 4 years ago

astrochun commented 4 years ago

Following @dhimmel's suggestions. I think it was easier to create a new pull request, so I closed out #6

dhimmel commented 4 years ago

Thanks @astrochun for the documentation improvement. I've merged this pull request.

I think it was easier to create a new pull request, so I closed out #6

For future reference, the standard practice on github is to revise existing PRs rather than open new ones after receiving feedback.

Cheers!

astrochun commented 4 years ago

@dhimmel. I actually tried to revise the original request. I made the additional changes in my forked repo, and then went to do a pull request to merge the changes with #6 but for some reason it did not work.

dhimmel commented 4 years ago

got it. yeah it's a bit confusing. If you make commits to the branch that the PR is coming from, those commits will automatically show up on the PR. I think your commit actually showed up on #6.