search

cognoma / frontend

Frontend for Project Cognoma
http://cognoma.org/
Other
4 stars 22 forks source link

gene auto-complete in mutations is kind of wacky #109

Closed leipzig closed 6 years ago

leipzig commented 7 years ago

type in GRIN - suggests CAMK4 ACSBG1 GSR NR3C1 DCAF6 type in GRIN2 - suggests GPRIN2 type in GRIN2A - suggests GRIN2A GRIN2D GRIN2B

ramenhog commented 6 years ago

@dhimmel our search input placeholder text for mutations says "search by name". Do we want that or would researchers rather search by symbol?

dhimmel commented 6 years ago

Currently, I see "Search genes by name". I think you could shorten to "Search genes", since our search will look up both symbols and names.

ramenhog commented 6 years ago

@dhimmel Sorry, my question was confusing. I was more asking if we wanted to user to use the "simple query" search or have them search by a particular field like "name" or "symbol"?

These are the results I'm getting with the simple query service mygene.info provides for "camk":

screen shot 2018-02-12 at 4 45 03 pm

Is that alright? It seems to return genes like DCLK2 that don't contain that sequence of letters since it technically searches for everything. I'm not sure there's a way around that unless we do a fielded search, but that also returns interesting results...

dhimmel commented 6 years ago

That's because DCLK2 previously used the symbol DCAMKL2. So this is actually working as intended.

If we have problems, we could look into tweaking the mygene.info query. I know there are some things that can be tuned, but not a priority at this time.

ramenhog commented 6 years ago

Cool beans. This make it a smaller PR then 🙌