fix unit tests - Githubissues

cognoma / frontend

Frontend for Project Cognoma

http://cognoma.org/

Other

4 stars 22 forks source link

fix unit tests #114

Closed ramenhog closed 6 years ago

ramenhog commented 6 years ago

Issue Number

https://github.com/cognoma/frontend/issues/115

Purpose/Implementation Notes

fix existing unit tests so tests can pass in CircleCI
updated SauceLabs download url
removed karma-coverage for now (will reevaluate later)

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Functional tests

ran unit tests locally and verified they all pass

Checklist

Put an x in the boxes that apply.

[x] Lint and unit tests pass locally with my changes
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added necessary documentation (if appropriate)
[x] Any dependent changes have been merged and published in downstream modules

ramenhog commented 6 years ago

@dongbohu this is ready for review

ramenhog commented 6 years ago

@dongbohu should be good!